This commit is contained in:
@@ -0,0 +1,41 @@
|
||||
package action_commit_test
|
||||
|
||||
import (
|
||||
"errors"
|
||||
"testing"
|
||||
|
||||
commitcontract "git.cin.su/m/Assistant/contracts/commit"
|
||||
"git.cin.su/m/Assistant/contracts/continuity"
|
||||
commitdomain "git.cin.su/m/Assistant/modules/commit/domain"
|
||||
"git.cin.su/m/Assistant/platform/ids"
|
||||
)
|
||||
|
||||
func TestContinuityOperationRequiresExactAllowlistedEnvelope(t *testing.T) {
|
||||
context, proposal := testContextAndProposal()
|
||||
proposal.CapabilityID = commitcontract.CapabilityContinuityTransition
|
||||
proposal.Operation = commitcontract.OperationSatisfyDelivered
|
||||
proposal.ContinuitySubject = continuity.SatisfyDeliveredSubject{
|
||||
ProspectiveItemID: "prospective-1",
|
||||
ExpectedRevision: 4,
|
||||
FromState: continuity.ProspectiveDelivered,
|
||||
ToState: continuity.ProspectiveSatisfied,
|
||||
EvidenceRef: "artifact://evidence/1",
|
||||
}
|
||||
action, err := commitdomain.Authorize(proposal, context, validator{}, commitcontract.AuthorizedActionID(ids.ID("authorized-continuity")), 10)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if action.PrincipalID != context.Binding.PrincipalID || action.GrantRevision != context.Grant.Revision || action.AuthorizedAtUnixMillis != 10 {
|
||||
t.Fatalf("authorized envelope lost authority evidence: %#v", action)
|
||||
}
|
||||
|
||||
proposal.Operation = "arbitrary-operation"
|
||||
if _, err := commitdomain.Authorize(proposal, context, validator{}, "rejected", 10); !errors.Is(err, commitdomain.ErrInvalidProposal) {
|
||||
t.Fatalf("arbitrary operation error = %v", err)
|
||||
}
|
||||
proposal.Operation = commitcontract.OperationSatisfyDelivered
|
||||
proposal.ContinuitySubject.EvidenceRef = " "
|
||||
if _, err := commitdomain.Authorize(proposal, context, validator{}, "rejected-evidence", 10); !errors.Is(err, commitdomain.ErrInvalidProposal) {
|
||||
t.Fatalf("empty evidence error = %v", err)
|
||||
}
|
||||
}
|
||||
@@ -5,7 +5,6 @@ import (
|
||||
"testing"
|
||||
|
||||
"git.cin.su/m/Assistant/contracts/authority"
|
||||
"git.cin.su/m/Assistant/contracts/capability"
|
||||
commitcontract "git.cin.su/m/Assistant/contracts/commit"
|
||||
"git.cin.su/m/Assistant/contracts/identity"
|
||||
"git.cin.su/m/Assistant/contracts/work"
|
||||
@@ -30,7 +29,7 @@ func (unknownExecutor) Execute(commitcontract.AuthorizedAction) ports.ExecutionR
|
||||
func TestWS003RejectsRevokedGrantAndNeverExecutesProposalDirectly(t *testing.T) {
|
||||
context, proposal := testContextAndProposal()
|
||||
context.Grant.Active = false
|
||||
_, err := commitdomain.Authorize(proposal, context, validator{}, commitcontract.AuthorizedActionID(ids.ID("authorized")))
|
||||
_, err := commitdomain.Authorize(proposal, context, validator{}, commitcontract.AuthorizedActionID(ids.ID("authorized")), 1)
|
||||
if !errors.Is(err, authoritydomain.ErrInvalidGrant) {
|
||||
t.Fatalf("authorization error = %v, want invalid grant", err)
|
||||
}
|
||||
@@ -39,7 +38,7 @@ func TestWS003RejectsRevokedGrantAndNeverExecutesProposalDirectly(t *testing.T)
|
||||
func TestWS003RejectsMissingActorPrincipalBinding(t *testing.T) {
|
||||
context, proposal := testContextAndProposal()
|
||||
context.Binding.Active = false
|
||||
_, err := commitdomain.Authorize(proposal, context, validator{}, commitcontract.AuthorizedActionID(ids.ID("authorized")))
|
||||
_, err := commitdomain.Authorize(proposal, context, validator{}, commitcontract.AuthorizedActionID(ids.ID("authorized")), 1)
|
||||
if !errors.Is(err, authoritydomain.ErrInvalidGrant) {
|
||||
t.Fatalf("authorization error = %v, want invalid grant", err)
|
||||
}
|
||||
@@ -47,7 +46,7 @@ func TestWS003RejectsMissingActorPrincipalBinding(t *testing.T) {
|
||||
|
||||
func TestWS003UnknownOutcomeBlocksBlindRetry(t *testing.T) {
|
||||
context, proposal := testContextAndProposal()
|
||||
action, err := commitdomain.Authorize(proposal, context, validator{}, commitcontract.AuthorizedActionID(ids.ID("authorized")))
|
||||
action, err := commitdomain.Authorize(proposal, context, validator{}, commitcontract.AuthorizedActionID(ids.ID("authorized")), 1)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
@@ -67,6 +66,6 @@ func testContextAndProposal() (commitdomain.AuthorizationContext, commitcontract
|
||||
scope := authority.Scope{ID: authority.ScopeID(ids.ID("global")), Global: true, Label: "all"}
|
||||
grant := authority.AuthorityGrant{ID: authority.GrantID(ids.ID("grant")), ActorID: actor, PrincipalID: principal, ScopeID: scope.ID, Class: authority.GrantClassCreator, Revision: 1, Active: true}
|
||||
context := commitdomain.AuthorizationContext{Binding: identity.PrincipalBinding{ActorID: actor, PrincipalID: principal, Active: true}, Scope: scope, Grant: grant}
|
||||
proposal := commitcontract.ActionProposal{IntentID: commitcontract.ActionIntentID(ids.ID("intent")), ActorID: actor, CapabilityID: capability.CapabilityID(ids.ID("executor")), Target: work.TaskTarget{TaskID: work.TaskID(ids.ID("task")), GoalID: work.GoalID(ids.ID("goal")), ScopeID: scope.ID, Revision: 1}, Operation: "mutate-external-world"}
|
||||
proposal := commitcontract.ActionProposal{IntentID: commitcontract.ActionIntentID(ids.ID("intent")), ActorID: actor, CapabilityID: commitcontract.CapabilityTestExecutor, Target: work.TaskTarget{TaskID: work.TaskID(ids.ID("task")), GoalID: work.GoalID(ids.ID("goal")), ScopeID: scope.ID, Revision: 1}, Operation: commitcontract.OperationTestIdempotentEffect}
|
||||
return context, proposal
|
||||
}
|
||||
|
||||
@@ -12,7 +12,7 @@ import (
|
||||
|
||||
func TestWS003UnknownOutcomeReconcilesWithoutDuplicateEffect(t *testing.T) {
|
||||
context, proposal := testContextAndProposal()
|
||||
action, err := commitdomain.Authorize(proposal, context, validator{}, commitcontract.AuthorizedActionID(ids.ID("authorized-reconcile")))
|
||||
action, err := commitdomain.Authorize(proposal, context, validator{}, commitcontract.AuthorizedActionID(ids.ID("authorized-reconcile")), 1)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
@@ -34,7 +34,7 @@ func TestWS003UnknownOutcomeReconcilesWithoutDuplicateEffect(t *testing.T) {
|
||||
|
||||
func TestWS003ReconciliationRequiresUnknownOutcome(t *testing.T) {
|
||||
context, proposal := testContextAndProposal()
|
||||
action, err := commitdomain.Authorize(proposal, context, validator{}, commitcontract.AuthorizedActionID(ids.ID("authorized-invalid-reconcile")))
|
||||
action, err := commitdomain.Authorize(proposal, context, validator{}, commitcontract.AuthorizedActionID(ids.ID("authorized-invalid-reconcile")), 1)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user