fix: preserve learning evidence integrity

This commit is contained in:
m
2026-08-22 02:43:06 +03:00
parent 01f4fa27c2
commit 8a3b085855
8 changed files with 144 additions and 14 deletions
+4 -4
View File
@@ -42,13 +42,13 @@ func ObserveSkillOutcome(profile capability.SkillProfile, observation capability
}
next.LastValidatedUnixMillis = observation.ObservedAtUnixMillis
next.ConfidenceMillis = clampConfidence(next.ConfidenceMillis + 25)
case capability.UsageFailed, capability.UsageUnknown:
case capability.UsageFailed:
next.KnownFailureExperienceRefs = appendEvidenceRef(next.KnownFailureExperienceRefs, observation.ExperienceRef)
next.ObservedFailureCount++
next.ConfidenceMillis = clampConfidence(next.ConfidenceMillis - 150)
case capability.UsageSkipped:
next.KnownFailureExperienceRefs = appendEvidenceRef(next.KnownFailureExperienceRefs, observation.ExperienceRef)
next.ConfidenceMillis = clampConfidence(next.ConfidenceMillis - 25)
case capability.UsageUnknown, capability.UsageSkipped:
// UNKNOWN and SKIPPED are evidence of incomplete observation or a safe
// non-application, not evidence that the skill itself failed.
default:
return capability.SkillProfile{}, ErrInvalidSkillProfile
}
+14
View File
@@ -44,6 +44,20 @@ func TestValidatedSkillCanApplyFastPathWhenFreshAndConfident(t *testing.T) {
}
}
func TestUnknownAndSkippedOutcomesDoNotBecomeSkillFailures(t *testing.T) {
profile := skillProfile()
for _, outcome := range []capability.UsageOutcomeClass{capability.UsageUnknown, capability.UsageSkipped} {
next, err := ObserveSkillOutcome(profile, capability.SkillOutcomeObservation{ExperienceRef: capability.SkillEvidenceRef("experience:" + string(outcome)), Outcome: outcome, ObservedAtUnixMillis: profile.RecordedAtUnixMillis + 1})
if err != nil {
t.Fatal(err)
}
if next.ObservedFailureCount != profile.ObservedFailureCount || len(next.KnownFailureExperienceRefs) != len(profile.KnownFailureExperienceRefs) || next.ConfidenceMillis != profile.ConfidenceMillis {
t.Fatalf("outcome %q was incorrectly recorded as failure: %#v", outcome, next)
}
profile = next
}
}
func skillProfile() capability.SkillProfile {
return capability.SkillProfile{
ID: "skill-obvious-reminder-response-v1",