feat: add isolated governed scaffold candidate
This commit is contained in:
@@ -11,6 +11,7 @@ import (
|
||||
var ErrInvalidDevelopmentGate = errors.New("invalid governed self-development gate")
|
||||
var ErrInsufficientExtensionEvidence = errors.New("insufficient repeated extension evidence")
|
||||
var ErrInvalidExtensionProposal = errors.New("invalid extension proposal")
|
||||
var ErrInvalidDevelopmentScaffold = errors.New("invalid development scaffold candidate")
|
||||
|
||||
// BuildExtensionProposal deterministically turns a repeated evidence signal
|
||||
// into a proposal. It retains every distinct evidence reference for lineage,
|
||||
@@ -86,6 +87,64 @@ func cleanStrings(values []string) []string {
|
||||
return result
|
||||
}
|
||||
|
||||
// BuildDevelopmentScaffold creates only a typed, isolated candidate. The
|
||||
// caller supplies the protected path set so this domain function cannot infer
|
||||
// or widen repository authority from ambient process state.
|
||||
func BuildDevelopmentScaffold(request work.DevelopmentScaffoldRequest) (work.DevelopmentScaffold, error) {
|
||||
modules := cleanStrings(request.Modules)
|
||||
allowed := cleanPaths(request.AllowedPaths)
|
||||
forbidden := cleanPaths(request.ForbiddenPaths)
|
||||
protected := cleanPaths(request.ProtectedPaths)
|
||||
tests := cleanStrings(request.RequiredTests)
|
||||
lineage := cleanStrings(request.ArtifactLineageRefs)
|
||||
if request.ID == "" || request.ProposalRef == "" || strings.TrimSpace(request.BaseRepoRevision) == "" || strings.TrimSpace(request.WorktreeRef) == "" || strings.TrimSpace(request.TaskIntent) == "" || request.CreatedAt.IsZero() || len(modules) == 0 || len(allowed) == 0 || len(tests) == 0 || len(lineage) == 0 || request.ProtectedMainAccess != "DENIED" || request.ProductionAccess != "DENIED" || request.SecretAccess != "DENIED" {
|
||||
return work.DevelopmentScaffold{}, ErrInvalidDevelopmentScaffold
|
||||
}
|
||||
for _, path := range allowed {
|
||||
if unsafePath(path) || pathMatchesAny(path, forbidden) || pathMatchesAny(path, protected) {
|
||||
return work.DevelopmentScaffold{}, ErrInvalidDevelopmentScaffold
|
||||
}
|
||||
}
|
||||
worktree := strings.ToLower(strings.TrimSpace(request.WorktreeRef))
|
||||
if worktree == "main" || worktree == "protected-main" || worktree == "production" {
|
||||
return work.DevelopmentScaffold{}, ErrInvalidDevelopmentScaffold
|
||||
}
|
||||
return work.DevelopmentScaffold{ID: request.ID, Stage: work.DevelopmentScaffoldSandboxed, ProposalRef: request.ProposalRef, BaseRepoRevision: strings.TrimSpace(request.BaseRepoRevision), WorktreeRef: strings.TrimSpace(request.WorktreeRef), TaskIntent: strings.TrimSpace(request.TaskIntent), Modules: modules, AllowedPaths: allowed, ForbiddenPaths: forbidden, RequiredTests: tests, ArtifactLineageRefs: lineage, ProtectedMainAccess: "DENIED", ProductionAccess: "DENIED", SecretAccess: "DENIED", CreatedAtUnixMillis: request.CreatedAt.UnixMilli()}, nil
|
||||
}
|
||||
|
||||
func cleanPaths(values []string) []string {
|
||||
result := make([]string, 0, len(values))
|
||||
seen := make(map[string]struct{}, len(values))
|
||||
for _, value := range values {
|
||||
value = strings.TrimSpace(strings.ReplaceAll(value, "\\", "/"))
|
||||
if value == "" {
|
||||
continue
|
||||
}
|
||||
if _, ok := seen[value]; ok {
|
||||
continue
|
||||
}
|
||||
seen[value] = struct{}{}
|
||||
result = append(result, value)
|
||||
}
|
||||
return result
|
||||
}
|
||||
|
||||
func unsafePath(path string) bool {
|
||||
return strings.HasPrefix(path, "/") || strings.HasPrefix(path, "~") || (len(path) > 1 && path[1] == ':') || slices.Contains(strings.Split(path, "/"), "..")
|
||||
}
|
||||
|
||||
func pathMatchesAny(path string, scopes []string) bool {
|
||||
for _, scope := range scopes {
|
||||
scope = strings.TrimSuffix(scope, "/")
|
||||
scope = strings.TrimSuffix(scope, "**")
|
||||
scope = strings.TrimSuffix(scope, "/")
|
||||
if path == scope || strings.HasPrefix(path, scope+"/") {
|
||||
return true
|
||||
}
|
||||
}
|
||||
return false
|
||||
}
|
||||
|
||||
func AdvanceDevelopmentGate(current work.DevelopmentGate, next work.DevelopmentStage) (work.DevelopmentGate, error) {
|
||||
if err := ValidateDevelopmentGate(current); err != nil {
|
||||
return work.DevelopmentGate{}, err
|
||||
|
||||
@@ -51,6 +51,22 @@ func TestBuildExtensionProposalRejectsSingleFailureAndIncompleteGovernance(t *te
|
||||
}
|
||||
}
|
||||
|
||||
func TestBuildDevelopmentScaffoldFailsClosedForProtectedScope(t *testing.T) {
|
||||
base := work.DevelopmentScaffoldRequest{ID: "scaffold-1", ProposalRef: "proposal-1", BaseRepoRevision: "abc123", WorktreeRef: "worktree-1", TaskIntent: "add reviewed adapter", Modules: []string{"capability"}, AllowedPaths: []string{"modules/capability/**"}, ForbiddenPaths: []string{"security/**"}, ProtectedPaths: []string{"architecture/**", "deploy/**"}, RequiredTests: []string{"go test ./..."}, ArtifactLineageRefs: []string{"proposal-1"}, ProtectedMainAccess: "DENIED", ProductionAccess: "DENIED", SecretAccess: "DENIED", CreatedAt: time.UnixMilli(1)}
|
||||
scaffold, err := BuildDevelopmentScaffold(base)
|
||||
if err != nil || scaffold.Stage != work.DevelopmentScaffoldSandboxed {
|
||||
t.Fatalf("valid scaffold rejected: %+v %v", scaffold, err)
|
||||
}
|
||||
base.AllowedPaths = []string{"deploy/docker-compose.prod.yml"}
|
||||
if _, err := BuildDevelopmentScaffold(base); err != ErrInvalidDevelopmentScaffold {
|
||||
t.Fatalf("protected path must fail closed, got %v", err)
|
||||
}
|
||||
base.AllowedPaths = []string{"modules/capability/../security"}
|
||||
if _, err := BuildDevelopmentScaffold(base); err != ErrInvalidDevelopmentScaffold {
|
||||
t.Fatalf("traversal path must fail closed, got %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestGovernedSelfDevelopmentRejectsSameProducerAndVerifier(t *testing.T) {
|
||||
gate := work.DevelopmentGate{ID: "dev-1", Stage: work.DevelopmentIsolated, EvidenceRefs: []string{"obs-1"}, ProducerRunRefs: []work.AgentRunID{"same"}, VerifierRunRefs: []work.AgentRunID{"same"}, VerificationEvidence: "verify-1"}
|
||||
if _, err := AdvanceDevelopmentGate(gate, work.DevelopmentVerified); err == nil {
|
||||
|
||||
Reference in New Issue
Block a user