feat: enable creator notification command
CI / test (pull_request) Successful in 11s
CI / test (push) Successful in 11s

This commit was merged in pull request #10.
This commit is contained in:
m
2026-08-16 19:19:00 +03:00
parent 6e0040fe89
commit c6139699a9
16 changed files with 622 additions and 18 deletions
+12
View File
@@ -1,6 +1,7 @@
package domain
import (
"encoding/hex"
"errors"
"strings"
@@ -71,11 +72,22 @@ func allowedOperation(proposal commitcontract.ActionProposal, context Authorizat
return subject.ProspectiveItemID != "" && subject.ExpectedRevision > 0 &&
subject.FromState == continuity.ProspectiveDelivered && subject.ToState == continuity.ProspectiveSatisfied &&
strings.TrimSpace(subject.EvidenceRef) != ""
case context.Grant.Class == authority.GrantClassCreator && proposal.CapabilityID == commitcontract.CapabilityProspectiveNotification && proposal.Operation == commitcontract.OperationDeliverProspectiveNotification:
subject := proposal.NotificationSubject
return subject.ProspectiveItemID != "" && subject.ExpectedRevision > 0 &&
subject.TemplateCode == commitcontract.ProspectiveDeliveredTemplateV1 && subject.BindingID != "" && subject.BindingRevision > 0 &&
strings.TrimSpace(subject.RenderedTitle) != "" && len(subject.RenderedTitle) <= 160 &&
strings.TrimSpace(subject.RenderedMessage) != "" && len(subject.RenderedMessage) <= 2048 && validDigest(subject.RequestDigest)
default:
return false
}
}
func validDigest(value string) bool {
decoded, err := hex.DecodeString(value)
return err == nil && len(decoded) == 32 && value == strings.ToLower(value)
}
// Execute records UNKNOWN_OUTCOME rather than silently retrying an ambiguous
// external mutation.
func Execute(action commitcontract.AuthorizedAction, attemptID commitcontract.ActionAttemptID, executor ports.Executor) (commitcontract.ActionAttempt, error) {
@@ -0,0 +1,46 @@
package domain
import (
"strings"
"testing"
"git.cin.su/m/Assistant/contracts/authority"
commitcontract "git.cin.su/m/Assistant/contracts/commit"
"git.cin.su/m/Assistant/contracts/work"
)
type allowValidator struct{}
func (allowValidator) Validate(authority.AuthorizationContext) error { return nil }
func notificationProposal() commitcontract.ActionProposal {
return commitcontract.ActionProposal{IntentID: "intent", ActorID: "actor", CapabilityID: commitcontract.CapabilityProspectiveNotification, Target: work.TaskTarget{TaskID: "task", GoalID: "goal", ScopeID: "scope", Revision: 1}, Operation: commitcontract.OperationDeliverProspectiveNotification, NotificationSubject: commitcontract.ProspectiveNotificationSubject{ProspectiveItemID: "item", ExpectedRevision: 1, TemplateCode: commitcontract.ProspectiveDeliveredTemplateV1, BindingID: "binding", BindingRevision: 1, RenderedTitle: "Домовой", RenderedMessage: "Пора вернуться", RequestDigest: strings.Repeat("a", 64)}}
}
func notificationContext() AuthorizationContext {
var context AuthorizationContext
context.Binding.ActorID, context.Binding.PrincipalID, context.Binding.Active = "actor", "owner", true
context.Scope = authority.Scope{ID: "scope"}
context.Grant = authority.AuthorityGrant{ID: "grant", ActorID: "actor", PrincipalID: "owner", ScopeID: "scope", Class: authority.GrantClassCreator, Revision: 1, Active: true}
return context
}
func TestAuthorizeProspectiveNotification(t *testing.T) {
action, err := Authorize(notificationProposal(), notificationContext(), allowValidator{}, "authorized", 1)
if err != nil {
t.Fatal(err)
}
if action.Proposal.Operation != commitcontract.OperationDeliverProspectiveNotification {
t.Fatal("operation changed")
}
}
func TestAuthorizeProspectiveNotificationRejectsInvalidEvidence(t *testing.T) {
for name, mutate := range map[string]func(*commitcontract.ActionProposal){"binding": func(p *commitcontract.ActionProposal) { p.NotificationSubject.BindingID = "" }, "digest": func(p *commitcontract.ActionProposal) { p.NotificationSubject.RequestDigest = "AA" }, "message": func(p *commitcontract.ActionProposal) { p.NotificationSubject.RenderedMessage = "" }, "operation": func(p *commitcontract.ActionProposal) { p.Operation = "arbitrary-webhook" }} {
t.Run(name, func(t *testing.T) {
proposal := notificationProposal()
mutate(&proposal)
if _, err := Authorize(proposal, notificationContext(), allowValidator{}, "authorized", 1); err == nil {
t.Fatal("expected denial")
}
})
}
}