Add agent dispatch intent contract

This commit is contained in:
m
2026-08-22 12:03:21 +03:00
parent 04dad79af1
commit f792d208ef
5 changed files with 64 additions and 2 deletions
+13
View File
@@ -48,3 +48,16 @@ type IndependentVerification struct {
Verified bool
Summary string
}
type AgentDispatchIntent struct {
DispatchID string
IdempotencyKey string
DelegationID DelegationID
RunID AgentRunID
ImplementationID string
ImplementationRevision int64
SourceRevision string
WorktreeID string
VerificationPlanRef string
CreatedAtUnixMillis int64
}
+2 -2
View File
@@ -1,5 +1,5 @@
{
"task_file": "dev/tasks/DEV-000119-independent-verification-contract.json",
"task_id": "DEV-000119",
"task_file": "dev/tasks/DEV-000120-agent-dispatch-intent.json",
"task_id": "DEV-000120",
"task_revision": 1
}
@@ -0,0 +1,23 @@
{
"task_id": "DEV-000120",
"task_revision": 1,
"architecture_revision": "ADR-0018",
"base_repo_revision": "04dad79",
"risk_tier": "E",
"intent": "Add typed durable dispatch intent and idempotency contract for agent runs without implementing a dispatcher, queue or worker process.",
"requirement_ids": ["WP-301", "Durable dispatch", "Duplicate dispatch prevention"],
"allowed_change_scope": {"modules": ["work-agent-execution"], "paths": ["contracts/work/**", "modules/work/domain/**", "tests/agent_execution/**", "dev/ACTIVE_TASK.json", "dev/tasks/DEV-000120-agent-dispatch-intent.json"]},
"forbidden_change_scope": {"paths": ["architecture/**", "database/**", "migrations/**", "deploy/**", "security/**", "cmd/**", "runtime/**", "adapters/**", ".gitea/**"]},
"allowed_architecture_delta": {"new_cross_module_dependencies": 0, "new_canonical_owners": 0, "new_privileges": 0, "new_third_party_dependencies": 0, "new_database_owner_roles": 0},
"contracts": {"consume": ["ADR-0017 delegation/run ownership", "ADR-0020 dispatch idempotency", "Existing Capability implementation identity"], "may_change": ["Work dispatch intent contract"]},
"semantic_owner": "work-agent-execution",
"canonical_state": [],
"state_transitions": ["dispatch intent -> accepted once by idempotency key -> lease acquisition", "same idempotency key -> same dispatch identity"],
"side_effects_and_privileges": ["Pure validation; no queue, process start, persistence adapter, credential access or external mutation"],
"persistence_and_migrations": ["No schema or migration changes"],
"failure_retry_restart": ["Retry reuses intent identity only when the durable store confirms the same payload; changed payload requires a new key"],
"assumptions": ["Dispatcher persists intent atomically later", "Exact source/worktree is resolved before worker start", "Verification plan is part of dispatch provenance"],
"acceptance_scenarios": ["Complete dispatch validates", "Missing idempotency/source/worktree/verification plan rejects", "Payload identity is explicit", "Worker implementation is typed and not inferred from free text"],
"required_tests": ["go test ./...", "go vet ./...", "go run ./cmd/devctl preflight -active dev/ACTIVE_TASK.json", "go run ./cmd/devctl check-diff -active dev/ACTIVE_TASK.json", "go run ./cmd/devctl check-architecture", "go run ./cmd/devctl/independent", "git diff --check", "dispatch intent tests"],
"terminal_gap_states": ["BLOCKED_BY_MISSING_CAPABILITY", "BLOCKED_BY_SPEC_GAP", "BLOCKED_BY_CONFLICT"]
}
+7
View File
@@ -39,3 +39,10 @@ func ValidateIndependentVerification(value work.IndependentVerification) error {
}
return nil
}
func ValidateDispatchIntent(value work.AgentDispatchIntent) error {
if value.DispatchID == "" || value.IdempotencyKey == "" || value.DelegationID == "" || value.RunID == "" || value.ImplementationID == "" || value.ImplementationRevision < 1 || value.SourceRevision == "" || value.WorktreeID == "" || value.VerificationPlanRef == "" || value.CreatedAtUnixMillis < 1 {
return ErrCallbackRejected
}
return nil
}
+19
View File
@@ -0,0 +1,19 @@
package agent_execution_test
import (
"testing"
"git.cin.su/m/Assistant/contracts/work"
workdomain "git.cin.su/m/Assistant/modules/work/domain"
)
func TestDispatchIntentRequiresStableExecutionIdentity(t *testing.T) {
intent := work.AgentDispatchIntent{DispatchID: "dispatch-1", IdempotencyKey: "idem-1", DelegationID: "delegation-1", RunID: "run-1", ImplementationID: "agent-1", ImplementationRevision: 2, SourceRevision: "commit-1", WorktreeID: "worktree-1", VerificationPlanRef: "verify-plan-1", CreatedAtUnixMillis: 10}
if err := workdomain.ValidateDispatchIntent(intent); err != nil {
t.Fatal(err)
}
intent.IdempotencyKey = ""
if err := workdomain.ValidateDispatchIntent(intent); err == nil {
t.Fatal("expected missing idempotency rejection")
}
}