cmd/cognitive-worker/advisory_test.go

@@ -1,15 +1,32 @@
 package main
 
 import (
+	"context"
 	"encoding/json"
 	"net/http"
 	"net/http/httptest"
+	"os"
+	"path/filepath"
 	"strings"
 	"testing"
 
+	"git.cin.su/m/Assistant/adapters/models"
 	"git.cin.su/m/Assistant/contracts/cognitive"
 )
 
+type stubAdvisoryProvider struct {
+	called   bool
+	request  cognitive.AdvisoryRequest
+	response cognitive.AdvisoryResponse
+	err      error
+}
+
+func (s *stubAdvisoryProvider) Advise(_ context.Context, request cognitive.AdvisoryRequest) (cognitive.AdvisoryResponse, error) {
+	s.called = true
+	s.request = request
+	return s.response, s.err
+}
+
 func TestDeterministicAdvisoryRejectsUnknownJSONField(t *testing.T) {
 	body := `{"Version":"creator-advisory-v1","Unexpected":"provider override"}`
 	request := httptest.NewRequest(http.MethodPost, "/v1/advisories/deterministic", strings.NewReader(body))
@@ -36,3 +53,90 @@ func TestDeterministicAdvisoryReturnsUnavailableContract(t *testing.T) {
 		t.Fatalf("unexpected response: %+v", advisory)
 	}
 }
+
+func TestOpenAIAdvisoryIsUnavailableBeforeBodyParsingWhenDisabled(t *testing.T) {
+	request := httptest.NewRequest(http.MethodPost, "/v1/advisories/openai", strings.NewReader(`not-json`))
+	response := httptest.NewRecorder()
+	openAIAdvisory(nil)(response, request)
+	if response.Code != http.StatusServiceUnavailable {
+		t.Fatalf("status=%d, want 503", response.Code)
+	}
+}
+
+func TestOpenAIAdvisoryStrictlyDecodesBeforeProvider(t *testing.T) {
+	provider := &stubAdvisoryProvider{}
+	request := httptest.NewRequest(http.MethodPost, "/v1/advisories/openai", strings.NewReader(`{"Version":"creator-advisory-v1","Unexpected":"provider override"}`))
+	response := httptest.NewRecorder()
+	openAIAdvisory(provider)(response, request)
+	if response.Code != http.StatusBadRequest || provider.called {
+		t.Fatalf("status=%d provider_called=%t", response.Code, provider.called)
+	}
+}
+
+func TestOpenAIAdvisoryReturnsProviderNeutralResponse(t *testing.T) {
+	provider := &stubAdvisoryProvider{response: cognitive.AdvisoryResponse{
+		Version:                 cognitive.CreatorAdvisoryV1,
+		RequestID:               "request-1",
+		ProviderBindingID:       models.OpenAIAdvisoryBindingID,
+		ProviderBindingRevision: models.OpenAIAdvisoryBindingRevision,
+		AdvisoryText:            "advice",
+		FinishReason:            cognitive.FinishCompleted,
+	}}
+	body := `{"Version":"creator-advisory-v1","RequestID":"request-1","ActorID":"actor","PrincipalID":"principal","ScopeID":"scope","Message":"help","Context":[],"Locale":"en","MaxOutputBytes":4096,"ProviderBindingID":"openai-responses-gpt-5.4-mini-2026-03-17","ProviderBindingRevision":1}`
+	request := httptest.NewRequest(http.MethodPost, "/v1/advisories/openai", strings.NewReader(body))
+	response := httptest.NewRecorder()
+	openAIAdvisory(provider)(response, request)
+	if response.Code != http.StatusOK || !provider.called || provider.request.Message != "help" {
+		t.Fatalf("status=%d provider_called=%t", response.Code, provider.called)
+	}
+	var advisory cognitive.AdvisoryResponse
+	if err := json.NewDecoder(response.Body).Decode(&advisory); err != nil {
+		t.Fatal(err)
+	}
+	if advisory.AdvisoryText != "advice" || advisory.FinishReason != cognitive.FinishCompleted {
+		t.Fatalf("unexpected response: %+v", advisory)
+	}
+}
+
+func TestLoadOpenAIAdvisoryProviderDefaultsDisabled(t *testing.T) {
+	t.Setenv("OPENAI_API_KEY", "")
+	provider, err := loadOpenAIAdvisoryProvider("")
+	if err != nil || provider != nil {
+		t.Fatalf("provider=%v error=%v", provider, err)
+	}
+}
+
+func TestLoadOpenAIAdvisoryProviderRejectsDirectEnvironmentCredential(t *testing.T) {
+	t.Setenv("OPENAI_API_KEY", "must-not-be-read")
+	if _, err := loadOpenAIAdvisoryProvider(""); err == nil || strings.Contains(err.Error(), "must-not-be-read") {
+		t.Fatalf("unexpected error: %v", err)
+	}
+}
+
+func TestLoadOpenAIAdvisoryProviderUsesBoundedSecretFile(t *testing.T) {
+	t.Setenv("OPENAI_API_KEY", "")
+	directory := t.TempDir()
+	validPath := filepath.Join(directory, "valid")
+	if err := os.WriteFile(validPath, []byte("test-project-key\n"), 0o600); err != nil {
+		t.Fatal(err)
+	}
+	provider, err := loadOpenAIAdvisoryProvider(validPath)
+	if err != nil || provider == nil {
+		t.Fatalf("provider=%v error=%v", provider, err)
+	}
+	for name, content := range map[string][]byte{
+		"empty":               nil,
+		"embedded whitespace": []byte("invalid key"),
+		"oversized":           []byte(strings.Repeat("x", maxOpenAISecretBytes+1)),
+	} {
+		t.Run(name, func(t *testing.T) {
+			path := filepath.Join(directory, name)
+			if err := os.WriteFile(path, content, 0o600); err != nil {
+				t.Fatal(err)
+			}
+			if _, err := loadOpenAIAdvisoryProvider(path); err == nil {
+				t.Fatal("invalid secret file was accepted")
+			}
+		})
+	}
+}

cmd/cognitive-worker/main.go

@@ -1,7 +1,11 @@
 package main
 
 import (
+	"bytes"
+	"context"
 	"encoding/json"
+	"errors"
+	"fmt"
 	"git.cin.su/m/Assistant/adapters/models"
 	"git.cin.su/m/Assistant/contracts/cognitive"
 	"git.cin.su/m/Assistant/runtime/health"
@@ -11,15 +15,26 @@ import (
 	"os"
 )
 
+const maxOpenAISecretBytes = 8 << 10
+
+type advisoryProvider interface {
+	Advise(context.Context, cognitive.AdvisoryRequest) (cognitive.AdvisoryResponse, error)
+}
+
 func main() {
 	addr := os.Getenv("LISTEN_ADDR")
 	if addr == "" {
 		addr = ":8083"
 	}
+	openAIProvider, err := loadOpenAIAdvisoryProvider(os.Getenv("OPENAI_API_KEY_FILE"))
+	if err != nil {
+		log.Fatal(err)
+	}
 	mux := http.NewServeMux()
 	mux.Handle("/healthz", health.Handler{Runtime: "cognitive-worker", SemanticGeneration: 1, ArchitectureGeneration: 1})
 	mux.HandleFunc("POST /v1/proposals/deterministic", deterministicProposal)
 	mux.HandleFunc("POST /v1/advisories/deterministic", deterministicAdvisory)
+	mux.HandleFunc("POST /v1/advisories/openai", openAIAdvisory(openAIProvider))
 	log.Printf("cognitive-worker listening on %s", addr)
 	if err := http.ListenAndServe(addr, mux); err != nil {
 		log.Fatal(err)
@@ -27,16 +42,8 @@ func main() {
 }
 
 func deterministicAdvisory(w http.ResponseWriter, r *http.Request) {
-	r.Body = http.MaxBytesReader(w, r.Body, 80*1024)
-	decoder := json.NewDecoder(r.Body)
-	decoder.DisallowUnknownFields()
-	var request cognitive.AdvisoryRequest
-	if err := decoder.Decode(&request); err != nil {
-		http.Error(w, "invalid advisory request", http.StatusBadRequest)
-		return
-	}
-	if err := decoder.Decode(&struct{}{}); err != io.EOF {
-		http.Error(w, "invalid advisory request", http.StatusBadRequest)
+	request, ok := decodeAdvisoryRequest(w, r)
+	if !ok {
 		return
 	}
 	response, err := models.DeterministicAdvisoryUnavailable(request)
@@ -48,6 +55,78 @@ func deterministicAdvisory(w http.ResponseWriter, r *http.Request) {
 	_ = json.NewEncoder(w).Encode(response)
 }
 
+func openAIAdvisory(provider advisoryProvider) http.HandlerFunc {
+	return func(w http.ResponseWriter, r *http.Request) {
+		if provider == nil {
+			http.Error(w, "provider unavailable", http.StatusServiceUnavailable)
+			return
+		}
+		request, ok := decodeAdvisoryRequest(w, r)
+		if !ok {
+			return
+		}
+		response, err := provider.Advise(r.Context(), request)
+		if err != nil {
+			http.Error(w, "invalid advisory request", http.StatusBadRequest)
+			return
+		}
+		w.Header().Set("Content-Type", "application/json")
+		_ = json.NewEncoder(w).Encode(response)
+	}
+}
+
+func decodeAdvisoryRequest(w http.ResponseWriter, r *http.Request) (cognitive.AdvisoryRequest, bool) {
+	r.Body = http.MaxBytesReader(w, r.Body, 80*1024)
+	decoder := json.NewDecoder(r.Body)
+	decoder.DisallowUnknownFields()
+	var request cognitive.AdvisoryRequest
+	if err := decoder.Decode(&request); err != nil {
+		http.Error(w, "invalid advisory request", http.StatusBadRequest)
+		return cognitive.AdvisoryRequest{}, false
+	}
+	if err := decoder.Decode(&struct{}{}); err != io.EOF {
+		http.Error(w, "invalid advisory request", http.StatusBadRequest)
+		return cognitive.AdvisoryRequest{}, false
+	}
+	return request, true
+}
+
+func loadOpenAIAdvisoryProvider(secretPath string) (advisoryProvider, error) {
+	if os.Getenv("OPENAI_API_KEY") != "" {
+		return nil, errors.New("direct OpenAI credential environment is forbidden; use OPENAI_API_KEY_FILE")
+	}
+	if secretPath == "" {
+		return nil, nil
+	}
+	file, err := os.Open(secretPath)
+	if err != nil {
+		return nil, fmt.Errorf("open OpenAI credential file: %w", err)
+	}
+	defer file.Close()
+	raw, err := io.ReadAll(io.LimitReader(file, maxOpenAISecretBytes+1))
+	if err != nil {
+		return nil, fmt.Errorf("read OpenAI credential file: %w", err)
+	}
+	defer clear(raw)
+	if len(raw) > maxOpenAISecretBytes {
+		return nil, errors.New("OpenAI credential file is oversized")
+	}
+	key := bytes.TrimSpace(raw)
+	if len(key) == 0 {
+		return nil, errors.New("OpenAI credential file is empty")
+	}
+	for _, character := range key {
+		if character < 0x21 || character > 0x7e {
+			return nil, errors.New("OpenAI credential file contains invalid characters")
+		}
+	}
+	provider, err := models.NewOpenAIAdvisoryAdapter(key, nil)
+	if err != nil {
+		return nil, errors.New("OpenAI credential file is invalid")
+	}
+	return provider, nil
+}
+
 func deterministicProposal(w http.ResponseWriter, r *http.Request) {
 	var request models.DeterministicRequest
 	if err := json.NewDecoder(r.Body).Decode(&request); err != nil {

dev/ACTIVE_TASK.json

@@ -1,5 +1,5 @@
 {
-  "task_file": "dev/tasks/DEV-000050-openai-advisory-adapter.json",
-  "task_id": "DEV-000050",
+  "task_file": "dev/tasks/DEV-000051-openai-advisory-runtime-gate.json",
+  "task_id": "DEV-000051",
   "task_revision": 1
 }

dev/tasks/DEV-000051-openai-advisory-runtime-gate.json

@@ -0,0 +1,23 @@
+{
+  "task_id": "DEV-000051",
+  "task_revision": 1,
+  "architecture_revision": "ADR-0007",
+  "base_repo_revision": "0ee9e4a8a11e4bf216007d288b07d74b4049cac5",
+  "risk_tier": "E",
+  "intent": "Add a fail-closed optional OpenAI advisory endpoint to cognitive-worker that can only initialize from a bounded secret file and remains unavailable by default, with no production compose, credential, egress or active Creator Web binding change.",
+  "requirement_ids": ["ADR-0006", "ADR-0007", "DEV-000050", "INV-EPI-001"],
+  "allowed_change_scope": {"modules": [], "paths": ["cmd/cognitive-worker/**", "docs/PROJECT_STATUS.md", "dev/ACTIVE_TASK.json", "dev/tasks/DEV-000051-openai-advisory-runtime-gate.json"]},
+  "forbidden_change_scope": {"paths": ["architecture/**", "ci/**", ".gitea/**", "contracts/**", "modules/**", "adapters/**", "cmd/core-runtime/**", "cmd/creator-web/**", "cmd/commit-runtime/**", "cmd/continuity-runtime/**", "database/**", "deploy/**", "security/**", "tests/**"]},
+  "allowed_architecture_delta": {"new_cross_module_dependencies": 0, "new_canonical_owners": 0, "new_privileges": 1, "new_third_party_dependencies": 0},
+  "contracts": {"consume": ["creator-advisory-v1", "OpenAIAdvisoryAdapter", "ADR-0007"], "may_change": []},
+  "semantic_owner": "none-cognitive-runtime-gate",
+  "canonical_state": [],
+  "state_transitions": [],
+  "side_effects_and_privileges": ["cognitive-worker code may read one explicitly configured OpenAI secret file and invoke the fixed adapter when a later deployment mounts it", "current production compose and Creator Web binding remain unchanged, so no provider call is activated"],
+  "persistence_and_migrations": [],
+  "failure_retry_restart": ["missing configuration keeps endpoint unavailable", "configured unreadable/empty/oversized secret fails startup", "invalid request fails before provider", "provider failures remain typed and are not retried", "restart loses no advisory state"],
+  "assumptions": ["the OpenAI secret file is absent from current production", "Creator Web continues to call deterministic endpoint", "docker-test remains prohibited"],
+  "acceptance_scenarios": ["default startup has no provider and deterministic fake remains usable", "OpenAI endpoint returns 503 before parsing/requesting when provider is disabled", "only a bounded secret file can initialize the adapter", "direct environment credential is unsupported", "strict request decoding and provider-neutral response encoding are preserved", "health/log responses expose no secret", "no deploy or Creator Web path changes activate egress"],
+  "required_tests": ["unit", "handler adversarial", "secret-file boundary", "go test ./...", "go vet ./...", "architecture preflight", "exact diff scope", "CI"],
+  "terminal_gap_states": ["BLOCKED_BY_ARCHITECTURE_GAP", "BLOCKED_BY_SPEC_GAP", "BLOCKED_BY_MISSING_CAPABILITY", "BLOCKED_BY_CONFLICT"]
+}

docs/PROJECT_STATUS.md

@@ -32,4 +32,6 @@ DEV-000049 adds and executes a repeatable production audit for that boundary. It
 
 ADR-0007 accepts OpenAI Responses API with immutable snapshot `gpt-5.4-mini-2026-03-17` and Mode A per-request retention disclosure as the first real provider binding class. DEV-000050 implements its standard-library adapter and adversarial fake-transport tests: fixed origin/payload, message-only egress, no tools or provider memory, redirect/proxy denial, no retry, strict output mapping and fail-closed timeout/refusal/unavailable/invalid states. The adapter is not wired into the runtime; production remains on `deterministic-fake` with no provider credential or egress.
 
+DEV-000051 adds an optional cognitive-worker runtime gate for that adapter. It is disabled when `OPENAI_API_KEY_FILE` is absent, rejects direct environment credentials, bounds and validates the secret file, and returns 503 before parsing an OpenAI request while disabled. Production configuration and Creator Web routing are unchanged, so the gate is not active and no provider egress occurs.
+
 These are explicit scope decisions, not hidden incomplete steps in DEV-000043. No production secret is stored in the repository.